libpsl: added version 0.21.5 #23642

laci-aura · 2024-04-18T10:38:29Z

Specify library name and version: libpsl/0.21.5

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

AbrilRBS

Thanks a lot! I have a question regarding the new option, but therest looks good :)

AbrilRBS · 2024-04-18T13:51:43Z

recipes/libpsl/all/conanfile.py

@@ -76,7 +79,11 @@ def generate(self):
        env.generate()
        tc = MesonToolchain(self)
        tc.project_options["runtime"] = self._idna_option
-        tc.project_options["builtin"] = self._idna_option
+        if Version(self.version) >= "0.21.5":
+            tc.project_options["builtin"] = self.options.enable_builtin


If this option is only valid from this version onward, it should be removed in the config_options() method so as to not influcence the pkgid of older versions :)

Also, this PR that tried to target an older release https://github.com/conan-io/conan-center-index/pull/22029/files#diff-308e90de1d7646e4db40d401de640dd72698dbb96cb43871ac4fb7bbd8eb8566R77

has it still check for the old ._idna_option. I take that yours is more extensible, but could you confirm what the original upstream intention is? Thanks! :)

No it should not be removed, older versions of the lib used to allow setting the 'builtin' option to the same values as the 'runtime' option (libicu, libidn, etc) but now they changed the meaning/possible values to just True/False.
I preserved compatibility with older versions

conan-center-index/recipes/libpsl/all/conanfile.py

Line 86 in 41dc055

tc.project_options["builtin"] = self._idna_option

Sorry took me a while to understand your comment :), fixed in 1e108a3

conan-center-bot · 2024-05-21T10:51:14Z

Conan v1 pipeline ❌

Failure in build 8 (66f8191a711231ac07f2e44702e9c38720fab62f):

libpsl/0.21.5:
CI failed to create some packages (All logs)

Logs for packageID 890c7524504368b09d4192b22cba9f1160ef1009:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=7
os=Linux
[options]
libpsl:shared=False

[...]
-----------------
[1/6] Compiling C object tools/psl.p/psl.c.o
[2/6] Generating src/suffixes_dafsa.h with a custom command
[3/6] Compiling C object src/libpsl.a.p/lookup_string_in_fixed_set.c.o
[4/6] Compiling C object src/libpsl.a.p/psl.c.o
[5/6] Linking static target src/libpsl.a
[6/6] Linking target tools/psl
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/ninja/1.11.1/_/_/package/24647d9fe8ec489125dfbae4b3ebefaf7581674c/bin/ninja -j 3
libpsl/0.21.5: Package '890c7524504368b09d4192b22cba9f1160ef1009' built
libpsl/0.21.5: Build folder /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/build/890c7524504368b09d4192b22cba9f1160ef1009/build-release
libpsl/0.21.5: Generated conaninfo.txt
libpsl/0.21.5: Generated conanbuildinfo.txt
libpsl/0.21.5: Generating the package
libpsl/0.21.5: Package folder /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/package/890c7524504368b09d4192b22cba9f1160ef1009
libpsl/0.21.5: Calling package()
libpsl/0.21.5: Copied 1 file: COPYING
libpsl/0.21.5: Copied 1 file: LICENSE

----Running------
> . "/home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/build/890c7524504368b09d4192b22cba9f1160ef1009/build-release/conan/conanbuild.sh" && meson install -C "/home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/build/890c7524504368b09d4192b22cba9f1160ef1009/build-release" --destdir "/home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/package/890c7524504368b09d4192b22cba9f1160ef1009"
-----------------
ninja: Entering directory `/home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/build/890c7524504368b09d4192b22cba9f1160ef1009/build-release'
ninja: no work to do.
Installing src/libpsl.a to /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/package/890c7524504368b09d4192b22cba9f1160ef1009/lib
Installing tools/psl to /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/package/890c7524504368b09d4192b22cba9f1160ef1009/bin
Installing /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/build/890c7524504368b09d4192b22cba9f1160ef1009/build-release/include/libpsl.h to /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/package/890c7524504368b09d4192b22cba9f1160ef1009/include
Installing /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/build/890c7524504368b09d4192b22cba9f1160ef1009/src/src/psl-make-dafsa.1 to /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/package/890c7524504368b09d4192b22cba9f1160ef1009/share/man/man1
Installing /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/build/890c7524504368b09d4192b22cba9f1160ef1009/src/tools/psl.1 to /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/package/890c7524504368b09d4192b22cba9f1160ef1009/share/man/man1
Installing /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/build/890c7524504368b09d4192b22cba9f1160ef1009/build-release/meson-private/libpsl.pc to /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/package/890c7524504368b09d4192b22cba9f1160ef1009/lib/pkgconfig
Installing /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/build/890c7524504368b09d4192b22cba9f1160ef1009/src/src/psl-make-dafsa to /home/conan/workspace/prod-v1/bsr/46157/ffcea/.conan/data/libpsl/0.21.5/_/_/package/890c7524504368b09d4192b22cba9f1160ef1009/bin
[HOOK - conan-center.py] post_package(): [PACKAGE LICENSE (KB-H012)] OK
[HOOK - conan-center.py] post_package(): [DEFAULT PACKAGE LAYOUT (KB-H013)] If you are trying to package a tool put all the contents under the 'bin' folder
[HOOK - conan-center.py] post_package(): [MATCHING CONFIGURATION (KB-H014)] OK
[HOOK - conan-center.py] post_package(): [SHARED ARTIFACTS (KB-H015)] OK
[HOOK - conan-center.py] post_package(): [STATIC ARTIFACTS (KB-H074)] OK
[HOOK - conan-center.py] post_package(): [EITHER STATIC OR SHARED OF EACH LIB (KB-H076)] OK
[HOOK - conan-center.py] post_package(): [PC-FILES (KB-H020)] OK
[HOOK - conan-center.py] post_package(): [CMAKE-MODULES-CONFIG-FILES (KB-H016)] OK
[HOOK - conan-center.py] post_package(): [PDB FILES NOT ALLOWED (KB-H017)] OK
[HOOK - conan-center.py] post_package(): [LIBTOOL FILES PRESENCE (KB-H018)] OK
[HOOK - conan-center.py] post_package(): [MS RUNTIME FILES (KB-H021)] OK
[HOOK - conan-center.py] post_package(): [SHORT_PATHS USAGE (KB-H066)] OK
[HOOK - conan-center.py] post_package(): [MISSING SYSTEM LIBS (KB-H043)] OK
[HOOK - conan-center.py] post_package(): [APPLE RELOCATABLE SHARED LIBS (KB-H077)] OK

Generating targets:   0%|          | 0/3 eta ?
                                              

Writing build.ninja:   0%|          | 0/32 eta ?
                                                
WARN: *** Conan 1 is legacy and on a deprecation path ***
WARN: *** Please upgrade to Conan 2 ***
libpsl/0.21.5: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
[HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'share' in the package (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H013-DEFAULT-PACKAGE-LAYOUT) 
ERROR: [HOOK - conan-center.py] post_package(): Some checks failed running the hook, check the output

libpsl/0.21.1:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

libpsl: added version 0.21.5

59dea09

conan-center-bot added the Service Under Maintenance label Apr 18, 2024

This comment has been minimized.

Sign in to view

Merge branch 'master' into laci-aura/add-libpsl-0.21.5

567ea31

laci-aura marked this pull request as ready for review April 18, 2024 10:41

This comment has been minimized.

Sign in to view

ghost mentioned this pull request Apr 18, 2024

[service] Potentially conflicting recipes #3571

Closed

libpsl: added the new version to config

41dc055

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Apr 18, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This was referenced Apr 18, 2024

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

ericLemanissier mentioned this pull request Apr 18, 2024

Updatable recipes ericLemanissier/conan-center-bot#1

Closed

AbrilRBS reviewed Apr 18, 2024

View reviewed changes

AbrilRBS self-assigned this Apr 18, 2024

libpsl: added removal of the enable_builtin option on older versions

1e108a3

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Service Under Maintenance labels Apr 18, 2024

This comment has been minimized.

Sign in to view

Merge branch 'master' into laci-aura/add-libpsl-0.21.5

13442d3

This comment has been minimized.

Sign in to view

laci-aura requested a review from AbrilRBS April 20, 2024 10:36

libpsl: updated meson to 1.4.0 for compatibility with python 3.12+

66f8191

ghost mentioned this pull request May 26, 2024

libpsl: add v0.21.2, bump deps, simplify patching #22029

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libpsl: added version 0.21.5 #23642

libpsl: added version 0.21.5 #23642

laci-aura commented Apr 18, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment

AbrilRBS Apr 18, 2024

AbrilRBS Apr 18, 2024

laci-aura Apr 18, 2024

laci-aura Apr 18, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented May 21, 2024

libpsl: added version 0.21.5 #23642

Are you sure you want to change the base?

libpsl: added version 0.21.5 #23642

Conversation

laci-aura commented Apr 18, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS Apr 18, 2024

Choose a reason for hiding this comment

AbrilRBS Apr 18, 2024

Choose a reason for hiding this comment

laci-aura Apr 18, 2024

Choose a reason for hiding this comment

laci-aura Apr 18, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented May 21, 2024

Conan v1 pipeline ❌